Esc

defer_frees_returned

Finds defer free(p); followed by return p;, which hands back freed memory.

Category correctness, deny by default.

Example
#import "Basic";
#import "String";

full_name :: (first: string) -> string {
    name := join(first, " Smith");
    defer free(name);
    return name;
}

main :: () {
    name := full_name("Ada");
    print("%\n", name);
}
Diagnostic
error[defer_frees_returned]: `name` is returned, but the `defer` above frees it
  --> example.jai:7:12
   |
 7 |     return name;
   |            ^^^^
   |
help: the deferred call runs after the value is returned: drop the `defer`, or return a copy
   |
 6 -     defer free(name);
   |
   = note: `defer_frees_returned` is `deny` by default
Fixed
#import "Basic";
#import "String";

full_name :: (first: string) -> string {
    name := join(first, " Smith");
    return name;
}

main :: () {
    name := full_name("Ada");
    print("%\n", name);
    free(name);
}

The defer must be a single call that frees its first argument, a local.